[FFmpeg-devel] [PATCH] 4xm: use reget_buffer() in decode_frame()

Stefano Sabatini stefano.sabatini-lala at poste.it
Tue Apr 26 11:59:55 CEST 2011


Also remove unnecessary call to avctx->release_buffer(). reget_buffer
is required since apparently the coded needs to be passed the previous
frame data again.

Releasing the frame and using get_buffer was working only in the case
get_buffer() was returning the old frame data again, and resulting in
playback artifacts otherwise.

Fix trac issue #85.

Signed-off-by: Stefano Sabatini <stefano.sabatini-lala at poste.it>
---
 libavcodec/4xm.c |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)

diff --git a/libavcodec/4xm.c b/libavcodec/4xm.c
index 97436ce..3a42642 100644
--- a/libavcodec/4xm.c
+++ b/libavcodec/4xm.c
@@ -773,12 +773,9 @@ static int decode_frame(AVCodecContext *avctx,
 
     avctx->flags |= CODEC_FLAG_EMU_EDGE; // alternatively we would have to use our own buffer management
 
-    if(p->data[0])
-        avctx->release_buffer(avctx, p);
-
     p->reference= 1;
-    if(avctx->get_buffer(avctx, p) < 0){
-        av_log(avctx, AV_LOG_ERROR, "get_buffer() failed\n");
+    if (avctx->reget_buffer(avctx, p) < 0) {
+        av_log(avctx, AV_LOG_ERROR, "reget_buffer() failed\n");
         return -1;
     }
 
-- 
1.7.2.3



More information about the ffmpeg-devel mailing list