[FFmpeg-devel] [PATCH] DVB Subtitles Fix
Carl Eugen Hoyos
cehoyos at ag.or.at
Wed Apr 27 02:08:17 CEST 2011
JULIAN GARDNER <joolzg <at> btinternet.com> writes:
[...]
> - h->rects[object_id]->h >> 1);
> + h->rects[object_id]->h >> 1);
This looks unrelated / unintended.
[...]
> - if (depth & 0x80)
> - clut->clut4[entry_id] = RGBA(r,g,b,255 - alpha);
> + if (depth & 0x80)
> + clut->clut4[entry_id] = RGBA(r,g,b,255 - alpha);
Please make your patch smaller (and easier to review) by not re-indenting these
lines.
Feel free to wait for a real review, Carl Eugen
More information about the ffmpeg-devel
mailing list