[FFmpeg-devel] [libav-devel] [PATCH] qpeg: use reget_buffer() in decode_frame()

[Stefano Sabatini]

On date Wednesday 2011-04-27 17:02:32 -0400, Ronald S. Bultje encoded:
> Hi,
> 
> On Wed, Apr 27, 2011 at 4:59 PM, Reimar Döffinger
> <Reimar.Doeffinger at gmx.de> wrote:
> >> That is incorrect. reference=1 means only the top field is referenced.
> >> You need to set reference=3. (Not that it matters, but just to be
> >> correct.)
> >
> > There's obviously a lot of codecs that need fixing in that regard,
> > at least all recently changed to reget_buffer.
> > Obvious question is what that reference=0 is there, I naively
> > would assume that someone had a reason. I guess I'm most likely
> > wrong though.
> 
> Looks like a mistake to me also.

I also note that having an int for the "reference" field doesn't help
to understand its meaning. Expect a patch for converting the int to an
enum.
-- 
FFmpeg = Frightening and Faithful Multimedia Plastic Energized God