[FFmpeg-devel] [PATCH] encoder for adobe's flash ScreenVideo2 codec

[Daniel Verkamp]

On Thu, Apr 28, 2011 at 5:30 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> On Wed, Jul 22, 2009 at 11:10:45AM -0600, Joshua Warner wrote:
>> Him
>>
>> I fixed the issues you guys have commented on (tell me if I
>> accidentally missed one), and the revised patch is attached.
>
> Applied locally will push to main ffmpeg git
> it makes no sense to let this rot in the ML archives just because its
> not perfect
>

Thanks for merging this!

However, a quick test encoding this sample shows a problem:
  http://drv.nu/temp/flashsv2/screen.flv

Around 2-4 seconds into the video, some blocks are corrupted.

Reverting 4517ba092e0606e9473c8e148c9895b01f975e18 ("flashsv2enc:fix
segfault") fixes the problem for this sample.  I could not reproduce
the mentioned segfault.  I don't understand how that code is supposed
to work, but it looks like moving the FFSWAP past the use of
s->keybuffer - s->encbuffer will definitely change the results.

Thanks,
-- Daniel Verkamp