[FFmpeg-devel] [PATCH] Lowercase the FRWU codec name
Stefano Sabatini
stefano.sabatini-lala at poste.it
Sat Apr 30 17:06:48 CEST 2011
On date Saturday 2011-04-30 15:40:30 +0200, ami_stuff encoded:
> the patch changes this
>
> [...]
> D A 8svx_exp 8SVX exponential
> D A 8svx_fib 8SVX fibonacci
> D V D FRWU Forward Uncompressed
> EV a64multi Multicolor charset for Commodore 64
> EV a64multi5 Multicolor charset for Commodore 64, extended with 5th color (colram)
> [...]
>
> to
>
> [...]
> DEVSD flv Flash Video (FLV) / Sorenson Spark / Sorenson H.263
> D V D fraps Fraps
> D V D frwu Forward Uncompressed
> DEA g722 G.722 ADPCM
> DEA g726 G.726 ADPCM
> [...]
>
>
> and
>
>
> [...]
> Stream #0.0: Video: FRWU, uyvy422, 192x144, 23.97 tbr, 23.97 tbn, 23.97 tbc
> [...]
>
> to
>
> [...]
> Stream #0.0: Video: frwu, uyvy422, 192x144, 23.97 tbr, 23.97 tbn, 23.97 tbc
> [...]
>
>
> I think it's better, bacause with
>
> ffmpeg -i file.avi
>
> when you get a uppercase codec name, it is mostly an unsupported one by ffmpeg.
>
> diff --git a/libavcodec/frwu.c b/libavcodec/frwu.c
> index 306166b..51324c2 100644
> --- a/libavcodec/frwu.c
> +++ b/libavcodec/frwu.c
> @@ -27,7 +27,7 @@
> static av_cold int decode_init(AVCodecContext *avctx)
> {
> if (avctx->width & 1) {
> - av_log(avctx, AV_LOG_ERROR, "FRWU needs even width\n");
> + av_log(avctx, AV_LOG_ERROR, "frwu needs even width\n");
> return -1;
> }
> avctx->pix_fmt = PIX_FMT_UYVY422;
> @@ -110,7 +110,7 @@ static av_cold int decode_close(AVCodecContext *avctx)
> }
>
> AVCodec ff_frwu_decoder = {
> - "FRWU",
> + "frwu",
> AVMEDIA_TYPE_VIDEO,
> CODEC_ID_FRWU,
> 0,
Fine with me (for consistency reasons, this is the only one shown
uppercased in ffmpeg -codecs), I'll apply soon if no one is against
this, thanks.
--
FFmpeg = Fostering Fostering Minimalistic Picky EnGine
More information about the ffmpeg-devel
mailing list