[FFmpeg-devel] [PATCH 1/2] Only add frame_delay to video_clock after the picture was actually queued

[Marton Balint]

On Sun, 31 Jul 2011, Michael Niedermayer wrote:
> On Fri, Jul 22, 2011 at 08:59:35PM +0200, Marton Balint wrote:
>> Video_refresh expects video_clock to contain the pts of the next frame which is
>> not yet in the queue.
>
> I assume you talk about:
> next_target= vp->target_clock + is->video_clock - vp->pts; //FIXME pass durations cleanly
>
> why not pass the durations cleanly instead? Is there some problem that
> makes this option non trivial?
>
> It seems more robust to me than moving the video_clock write around
> which is likely affected by race conditions

You are right. I will make a patch for it soon.

> anyway, sorry for my late awnser & thanks for looking into imroving
> ffplay

Thanks for your comments.

Regards,
   Marton

> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
>
> Awnsering whenever a program halts or runs forever is
> On a turing machine, in general impossible (turings halting problem).
> On any real computer, always possible as a real computer has a finite number
> of states N, and will either halt in less than N cycles or never halt.
>