[FFmpeg-devel] [PATCH 2/3] lavfi: fix doxygen doc for config_props() callback

[Michael Niedermayer]

On Thu, Aug 04, 2011 at 06:50:27PM +0200, Stefano Sabatini wrote:
> On date Thursday 2011-08-04 15:47:01 +0300, Mina Nagy Zaki encoded:
> > ---
> >  libavfilter/avfilter.h |   11 +++++++----
> >  1 files changed, 7 insertions(+), 4 deletions(-)
> > 
> > diff --git a/libavfilter/avfilter.h b/libavfilter/avfilter.h
> > index 1f26654..9e7a4cd 100644
> > --- a/libavfilter/avfilter.h
> > +++ b/libavfilter/avfilter.h
> > @@ -438,15 +438,18 @@ struct AVFilterPad {
> >      /**
> >       * Link configuration callback.
> >       *
> > -     * For output pads, this should set the link properties such as
> > -     * width/height. This should NOT set the format property - that is
> > -     * negotiated between filters by the filter system using the
> > +     * For output pads, this should set the following link properties:
> > +     * video: width, height, sample_aspect_ratio, time_base
> > +     * audio: sample_rate.
> > +     *
> > +     * This should NOT set properties such as format, channel_layout, etc which
> > +     * are negotiated between filters by the filter system using the
> >       * query_formats() callback before this function is called.
> >       *
> >       * For input pads, this should check the properties of the link, and update
> >       * the filter's internal state as necessary.
> >       *
> > -     * For both input and output filters, this should return zero on success,
> > +     * For both input and output pads, this should return zero on success,
> >       * and another value on error.
> >       */
> >      int (*config_props)(AVFilterLink *link);
> 
> Looks fine. I'll apply in a few days if I see no comments on it, maybe
> Michael?

LGTM

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Dictatorship naturally arises out of democracy, and the most aggravated
form of tyranny and slavery out of the most extreme liberty. -- Plato
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110804/d81feb84/attachment.asc>