[FFmpeg-devel] [PATCH 2/5] lavfi: add aformat filter

[Mina Nagy Zaki]

On Mon, Aug 08, 2011 at 11:39:05AM +0200, Stefano Sabatini wrote:
> On date Monday 2011-08-08 11:11:46 +0300, Mina Nagy Zaki encoded:
> 
> > +            fmt = ff_parse_sample_format(fmt_str, ctx);
> > +            if (fmt == -1) return AVERROR(EINVAL);
> 
> if ((fmt = ff_parse_sample_format(fmt_str, ctx)) < 0)
>    return ret;
> 
> better to avoid custom error code values
> 
> Same below, looks fine otherwise.
> [...]

Fixed.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-lavfi-add-aformat-filter.patch
Type: text/x-diff
Size: 6337 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110808/8032dbe4/attachment.bin>