[FFmpeg-devel] [PATCH] lavfi: port libmpcodecs delogo filter

[Stefano Sabatini]

On date Thursday 2011-08-11 10:32:23 +0200, Stefano Sabatini encoded:
> On date Thursday 2011-08-11 00:02:54 +0200, Nicolas George encoded:
> > Le tridi 23 thermidor, an CCXIX, Stefano Sabatini a écrit :
> > > Basically, same code, same license, same output, same syntax and same
> > > behavior, I just added support to more yuv formats.
> > 
> 
> > Your port seems based on an old version of the filter: in r33488, I added an
> > option to change the rectangle depending on the time. Is it on purpose or
> > just a race condition?
> > The changes should not be hard to merge at all, they only act at the center
> > of the processing.
> 
> I see, I was basing the port on the libavfilter/libmpcodecs
> code. Indeed now I see the MPlayer code is different, if my guess is
> right it is supporting option parsing (when was it added?).

No the parsing code is not changing how the options are parsed, but
maybe we should use named options here, I mean something like that:

delogo=x=100:y=0:band=10:w=100:h=70

which should also provide a more useful feedback in case of invalid
parameters (but would be inconsistent with the current syntax).

> For the file option we can add it in a second stage (maybe you could
> do it as an exercise?), but we should at least keep the filters syntax
> aligned, so I won't commit this yet.
-- 
FFmpeg = Fierce & Faithless Multimedia Perennial Elastic Guru