[FFmpeg-devel] [PATCH] vf_unsharp: extend/improve feedback for validity checks

[Michael Niedermayer]

On Sat, Aug 13, 2011 at 01:29:25AM +0200, Stefano Sabatini wrote:
> On date Saturday 2011-08-13 01:11:49 +0200, Stefano Sabatini encoded:
> > Abort for invalid too big values, and exactly state why the input
> > value is invalid.
> > 
> > In particular, avoid out-of-buffer access with too big values.
> > ---
> >  libavfilter/vf_unsharp.c |   20 ++++++++++++++------
> >  1 files changed, 14 insertions(+), 6 deletions(-)
> 
> Regarding the syntax, the mp=unsharp filter supports a format of the
> kind:
> [lc]XxY:AMOUNT
> 
> while unsharp supports only (awkward) positional parameters.
> 
> A better mixed solution would be to implement a syntax of the kind:
> [lc]=XxY+AMOUNT
> 
> for example:
> l=5x5+0.3:c=3x3-2.0
> 
> while back-supporting the old syntax.

the old code also seems to support l1:2 as a shorthand of l1x1:2 from
looking at the code

and iam not sure if using a = is a good idea, that makes
unsharp=l=5x5+0.3
and to me the double = looks a bit odd
but thats just my 2 cent

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 3
"Rare item" - "Common item with rare defect or maybe just a lie"
"Professional" - "'Toy' made in china, not functional except as doorstop"
"Experts will know" - "The seller hopes you are not an expert"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110814/527357ce/attachment.asc>