[FFmpeg-devel] [PATCH] Revert "oggdec:Correct duration"

[Nicolas George]

Le septidi 7 fructidor, an CCXIX, Andrew Scherkus a écrit :
> We got some Chromium bug reports about incorrect ogg durations last
> time we updated FFmpeg. I traced it back to 5901cd6... which was
> applied from an old patch from ffmpeg2theora.
> 
> It looks like someone else had already made a similar fix in
> 44a088e... which means that applying both patches made for incorrect
> duration calculations.

It seems you are right. I had noticed some time ago that the duration of Ogg
files was underestimated, and your patch seems to fix it on the one I just
tried:

Real length:                17:34.83465
Reported by current ffmpeg: 17:34.64
Reported by patched ffmpeg: 17:34.82

I am not oggdec's maintainer though.

Also, your mailer seems to have mangled your patch, it is full of no-break
spaces and can not be applied as is. It is not a problem for such a simple
patch, but you should try to fix the problem before next time.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110824/f8793bbf/attachment.asc>