[FFmpeg-devel] [PATCH] lavfi: unify asink_buffer and vsink_buffer API

[Michael Niedermayer]

On Sat, Aug 20, 2011 at 07:44:59PM +0200, Stefano Sabatini wrote:
> More generic, less code duplication.
> ---
>  avconv.c                    |    5 +-
>  ffmpeg.c                    |    5 +-
>  ffplay.c                    |    5 +-
>  libavdevice/lavfi.c         |   11 ++--
>  libavfilter/Makefile        |    2 +-
>  libavfilter/asink_abuffer.c |   97 ------------------------------
>  libavfilter/asink_abuffer.h |   47 ---------------
>  libavfilter/vsink_buffer.c  |  139 ++++++++++++++++++++++++++++++++++---------
>  libavfilter/vsink_buffer.h  |   38 +++++++++---
>  9 files changed, 155 insertions(+), 194 deletions(-)
>  delete mode 100644 libavfilter/asink_abuffer.c
>  delete mode 100644 libavfilter/asink_abuffer.h
> 
> diff --git a/avconv.c b/avconv.c
> index a5edc76..dac5e5a 100644
> --- a/avconv.c
> +++ b/avconv.c
> @@ -345,6 +345,7 @@ static int configure_video_filters(InputStream *ist, OutputStream *ost)
>      AVCodecContext *codec = ost->st->codec;
>      AVCodecContext *icodec = ist->st->codec;
>      enum PixelFormat pix_fmts[] = { codec->pix_fmt, PIX_FMT_NONE };
> +    AVBufferSinkParams buffersink_params = { .pixel_fmts = pix_fmts };

this will break abi each time a field is added to the struct
because the code cannot know how large (aka new ABI) the struct the
user allocated is

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110827/52a9dac6/attachment.asc>