[FFmpeg-devel] ffmpeg -s breaks aspect ration (regression)

[Michael Niedermayer]

On Tue, Aug 16, 2011 at 05:52:59PM +0200, Jean Delvare wrote:
> Hi Michael,
> 
> Thanks for your answer.
> 
> On Mon, 1 Aug 2011 11:42:13 +0200, Michael Niedermayer wrote:
> > Hi
> > 
> > On Wed, Jul 20, 2011 at 04:44:56PM +0200, Jean Delvare wrote:
> > > Last time I updated ffmpeg, I hit a problem where option -s breaks the
> > > aspect ratio. I bisected the repository and found that this regression
> > > was introduced by:
> > > 
> > > commit 7a11c82fb760619d0e17ca234381b50d6c675cc0
> > > Author: Michael Niedermayer <michaelni at gmx.at>
> > > Date:   Mon Jan 31 20:48:35 2011 +0100
> > > 
> > >     vsrc_buffer: add sample_aspect_ratio fields to arguments.
> > >     
> > >     This fixes aspect handling in ffmpeg.
> > >     
> > >     This is based on a patch by Baptiste.
> > >     
> > >     Signed-off-by: Anton Khirnov <anton at khirnov.net>
> > > 
> > > My input video looks like:
> > > 
> > > Stream #0.0[0x1e0]: Video: mpeg2video (Main), yuv420p, 720x576 [PAR 64:45 DAR 16:9], 9500 kb/s, 25 fps, 25 tbr, 90k tbn, 50 tbc
> > > 
> > > I am passing -s 640x360 to ffmpeg to get square pixels, before the bug
> > > I would get:
> > > 
> > > Stream #0.0(und): Video: mpeg4, yuv420p, 640x360 [PAR 1:1 DAR 16:9], 640 kb/s, 25 fps, 25 tbr, 25 tbn, 25 tbc
> > > 
> > > and the video would look OK. Since the commit above, I get:
> > > 
> > > Stream #0.0(und): Video: mpeg4, yuv420p, 640x360 [PAR 1:1 DAR 16:9], 743 kb/s, PAR 91:64 DAR 91:36, 25 fps, 25 tbr, 25 tbn, 25 tbc
> > 
> > This bug seems to have been fixed as i cannot reproduce this anymore
> 
> Really? I still can, with the latest ffmpeg straight from git. See by
> yourself:
> 
> khali at endymion:~/recordings> ffmpeg -i safari_3_reasm.mpg -s 640x360 -b 640k -vcodec mpeg4 -t 0:01:00 -an test7.avi
> ffmpeg version N-31916-g86ca51a, Copyright (c) 2000-2011 the FFmpeg developers

true, i can reproduce that, should be fixed with my next git push

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110827/8589ef30/attachment.asc>