[FFmpeg-devel] Image sequence file names
Robert Petka
robert.petka at gmail.com
Wed Aug 31 00:08:56 CEST 2011
Dňa 30. 8. 2011 22:17, Carl Eugen Hoyos wrote / napísal(a):
> Robert Petka<robert.petka<at> gmail.com> writes:
>
>> Patcheck writes just bunch of grep unrecognized option messages.
> trailing whitespace
> patch:23:+
>
> x==0 / x!=0 can be simplified to !x / x
> patch:87:+ if (dp != NULL) {
>
> missing } prior to else
> patch:52:+ else
>
> missing whitespace between keyword and ( (feel free to ignore)
> patch:24:+ for(i=length-1;i>=0;i--)
> patch:25:+ if(inPath[i] == '\\' || inPath[i] =='/')
> patch:28:+ if(i == -1) {
> patch:45:+ for(i=length-1;i>=0;i--) {
> patch:46:+ if(last_digit == -1) {
> patch:47:+ if(isdigit(path[i]))
> patch:50:+ if(isdigit(path[i]))
> patch:58:+ if(first_digit != -1) {
> patch:95:+ if(file_index != -1) {
> patch:96:+ if(file_index< min_index)
> patch:108:+ if(first_index == -1) {
>
> possibly unused variables
> possibly never read :length
> possibly never read :length
>
> Missing changelog entry (ignore if minor change)
>
> FFMIN/FFMAX
> + if(file_index< min_index)
> + min_index = file_index;
>
> Carl Eugen
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Thank you :)
I have updated msys to get it work here too. Please find attached patch
file. Last remaining messages from patcheck:
possibly unused variables
possibly never read :length
possibly never read :length
Missing changelog entry (ignore if minor change)
I can work on dirname replacement (mentioned by Georgi) tomorrow...
Cheers,
Robert
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: image_range.diff
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110831/b59dc3bd/attachment.ksh>
More information about the ffmpeg-devel
mailing list