[FFmpeg-devel] [PATCH] Port tinterlace filter from MPlayer.

[Alexander Strasser]

Hi Stefano!

Stefano Sabatini wrote:
> On date Tuesday 2011-08-30 20:37:36 +0200, Michael Niedermayer encoded:
> > On Tue, Aug 30, 2011 at 10:50:12AM +0200, Stefano Sabatini wrote:
[...]
> > > I'm going to apply the patch in a few days if I see no comments, then
> > > I'll remove the mp=tinterlace wrapper if there are no objections.
> > 
> > I think the mp filters should only be removed once mplayer switched
> > to libavfilter
> > The issue i see is mplayers will be improved and our native ones might
> > rot and then its nice to still have the wraper.
> 
> Yes, but 1. it's not sure it will switch to lavfi, 2. we'll need to
> keep them updated.
> 
> Anyway having the duplicated code doesn't particularly bother me, my
> only point is that sometimes the mp filters don't work very well
> (e.g. mp=tinterlace resets timestamps to 0), in that case maybe it's
> better to just remove them rather than having the user to discover
> that the wrapped filter doesn't work as expected.

  While they are potentially developed at two places, it might be handy
to have the wrapped filter around and test against it when updating the
lavfi implementation to accomodate a change in MPlayer.

  I am not very passionate about keeping it though. Just wanted to point
out that it might be useful. Maybe ffmpeg could output a message if a
user selected the wrapped mp filter and an lavfi replacement is available.
That would probably only be worth it if we decide on generally keeping
the wrapped filters around (until they are deleted from MPlayer repo).

  Alexander