[FFmpeg-devel] [PATCH] lavf: accept time base from untrusted codecs if it matches timings

[Michael Niedermayer]

On Tue, Feb 01, 2011 at 11:10:12AM -0500, Ronald S. Bultje wrote:
> Hi,
> 
> On Sun, Jan 30, 2011 at 2:33 PM, Anssi Hannula <anssi.hannula at iki.fi> wrote:
> > @@ -627,6 +627,8 @@ typedef struct AVStream {
> > ? ? ? ? int64_t last_dts;
> > ? ? ? ? int64_t duration_gcd;
> > ? ? ? ? int duration_count;
> > + ? ? ? ?int codec_tb_matches_dts;
> > + ? ? ? ?double codec_tb_dur_error;
> > ? ? ? ? double duration_error[MAX_STD_TIMEBASES];
> > ? ? ? ? int64_t codec_info_duration;
> > ? ? } *info;
> 
> These are only used in av_find_stream_info(), adding them to AVStream
> in the middle breaks ABI and increases size for something that I don't
> think should be in there.

Can you elaborate on that?


> Can you locally allocate and free an array
> instead,

thats would just be messy and fragile


> or create a AVFindStreamInfo array for these kind of temp
> values to be shared between functions?

you sound confused, do you actually understand the code you try to review?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Into a blind darkness they enter who follow after the Ignorance,
they as if into a greater darkness enter who devote themselves
to the Knowledge alone. -- Isha Upanishad
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110201/db1c9bce/attachment.pgp>