[FFmpeg-devel] [PATCH] Make avfilter_graph_free() free the graph.

[Måns Rullgård]

Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:

> On date Wednesday 2011-02-02 12:09:00 +0000, M?ns Rullg?rd encoded:
>> Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
>> 
>> > (Note to the committers: update minor).
>> > -- 
>> > FFmpeg = Fabulous Friendly Mean Ponderous Embarassing Gadget
>> >
>> >
>> >  /**
>> > - * Free a graph and destroy its links, graph may be NULL.
>> > + * Free a graph, destroy its links, and set *graph to NULL.
>> > + * If *graph is NULL, do nothing.
>> >   */
>> > -void avfilter_graph_free(AVFilterGraph *graph);
>> > +void avfilter_graph_free(AVFilterGraph **graph);
>> 
>> This is an API/ABI change.  That needs a major version bump.
>
> Yes, but currently we are considering lavfi still unstable, we (and me
> in particular) broke API/ABI many times in the past months. I want to
> wait more before to declare its API/ABI stable (pending audio
> filtering patches).

As long as everybody agrees, I'm fine with this.  I don't want angry
users complaining that their app is crashing.

> Anyway minor *should* be updated, eventually we can add a notice in

Yes, something should be updated.  I just wasn't sure minor was enough.

> APIchanges, as I did (inconsistently) in past occasions. And BTW this
> patch depends on the previous one or it will cause a crash on exit.

I'll push them at the same time.

> If we want to relegate lavfi development to a topic branch and synch
> from time to time this can be discussed.

Since you're quite actively working on it, to say the least, having a
dedicated branch/repo for lavfi would allow you to work as quickly as
you want, and the master would catch up from time to time.  This model
also has the advantage that when reviewing, one can look ahead in the
development branch and see where things are headed, thus helping to
understand the reason for making changes.  Without this path ahead
clear, some of your patches have seemed a bit mysterious in the past.

-- 
M?ns Rullg?rd
mans at mansr.com