[FFmpeg-devel] [PATCH 2/2] Add sample_aspect_ratio fields to vsrc_buffer arguments. This fixes aspect handling in ffmpeg This is based on a patch by baptiste

[Michael Niedermayer]

On Sat, Feb 05, 2011 at 04:27:32PM +0100, Stefano Sabatini wrote:
> On date Friday 2011-02-04 17:11:41 -0800, Baptiste Coudurier encoded:
> > On 02/04/2011 12:33 AM, Stefano Sabatini wrote:
> > >[...]
> > >
> > >  }
> > >@@ -2825,6 +2835,12 @@ static void opt_frame_pix_fmt(const char *arg)
> > >
> > >  static void opt_frame_aspect_ratio(const char *arg)
> > >  {
> > >+#if CONFIG_AVFILTER
> > >+    av_log(NULL, AV_LOG_ERROR,
> > >+           "Option 'aspect' is incompatible with filters, "
> > >+           "use -vf together with the setdar filter instead\n");
> > >+    ffmpeg_exit(1);
> > >+#else
> > 
> > Seriously guys, can you please stop this nonsense ?
> > -aspect is used with stream copy as well.
>
> New tentative approach, tested with CONFIG_AVFILTER = 1, -aspect N:D
> -vf F, -vf F -aspect N:D, stream copy and CONFIG_AVFILTER = 0,
> regression test passed.

dont forget to test that your cases get aspects both on init time as well as
per frame time correct

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Frequently ignored awnser#1 FFmpeg bugs should be sent to our bugtracker. User
questions about the command line tools should be sent to the ffmpeg-user ML.
And questions about how to use libav* should be sent to the libav-user ML.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110206/2fe5ad4a/attachment.pgp>