[FFmpeg-devel] [PATCH 1/2] avidec: get rid of some magic numbers in read_gab2_sub()

[Anton Khirnov]

On Sun, Feb 06, 2011 at 09:16:27PM +0100, Michael Niedermayer wrote:
> On Sun, Feb 06, 2011 at 08:31:55PM +0100, Anton Khirnov wrote:
> > On Sun, Feb 06, 2011 at 03:47:02PM +0100, Michael Niedermayer wrote:
> > > On Sun, Feb 06, 2011 at 03:17:57PM +0100, Reimar D?ffinger wrote:
> > > > On Sun, Feb 06, 2011 at 03:12:25PM +0100, Anton Khirnov wrote:
> > > > > On Sun, Feb 06, 2011 at 11:47:54AM +0100, Reimar D?ffinger wrote:
> > > > > > On Sun, Feb 06, 2011 at 11:07:05AM +0100, Anton Khirnov wrote:
> > > [...]
> > > > > > Also in case the AV_RL16 part is some kind of version number I would
> > > > > > consider this significantly worse, magic number or not.
> > > > > TBH I don't know what that number means, this "format" seems like an
> > > > > undocumented hack (and we can hope no new versions of it will ever be
> > > > > created).
> > > > > Anyway, I don't care much about this patch, I can drop it if you think
> > > > > it does more harm than good.
> > > > 
> > > > I don't care either, it just seems a bit pointless to me...
> > > 
> > > Id like to second this, and IMHO pointless changes should be avoided for
> > > keeping log & blame clean
> > Fine, first patch dropped.
> > Rebased second patch attached, please review.
> 
> me?
If you feel like it, yes. Surely it is more productive than flaming.
If not, then anybody else who does.
> i trust you to not mess up with such trivial simplification, if it has been
> tested
I don't trust myself to not mess up anything ;)


-- 
Anton Khirnov
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110206/93882beb/attachment.pgp>