[FFmpeg-devel] [PATCH] mp3enc: fix ISO-8859-1 range

[Daniel Verkamp]

On Sun, Feb 6, 2011 at 2:47 PM, Anton Khirnov <anton at khirnov.net> wrote:
> It starts on 32, not 1.
>
> Thanks to Arpi for spotting this.
> ---
> ?libavformat/mp3enc.c | ? ?2 +-
> ?1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/libavformat/mp3enc.c b/libavformat/mp3enc.c
> index 5921ded..d043296 100644
> --- a/libavformat/mp3enc.c
> +++ b/libavformat/mp3enc.c
> @@ -79,7 +79,7 @@ static void id3v2_put_size(AVFormatContext *s, int size)
>
> ?static int string_is_ascii(const uint8_t *str)
> ?{
> - ? ?while (*str && *str < 128) str++;
> + ? ?while (*str && *str >= 32 *str < 128) str++;

This looks plain wrong... you probably meant something like:
  while (*str >= 32 && *str < 128) str++;