[FFmpeg-devel] [PATCH 01/10] lavf: move ff_guidcmp from asfdec.c to asf.c

[Måns Rullgård]

Anton Khirnov <anton at khirnov.net> writes:

> ---
>  libavformat/asf.c    |    4 ++++
>  libavformat/asfdec.c |    5 -----
>  2 files changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/libavformat/asf.c b/libavformat/asf.c
> index 1f6af18..10fa422 100644
> --- a/libavformat/asf.c
> +++ b/libavformat/asf.c
> @@ -20,6 +20,10 @@
>
>  #include "asf.h"
>
> +int ff_guidcmp(const void *g1, const void *g2)
> +{
> +    return memcmp(g1, g2, sizeof(ff_asf_guid));
> +}

Why is this a function at all, and why is it in asf.c?  If calling
memcmp directly is too much trouble, I'd at make it a macro instead.

-- 
M?ns Rullg?rd
mans at mansr.com