[FFmpeg-devel] Possible bug in dvbsub.c

[Måns Rullgård]

Ronen Mizrahi <ronen at tversity.com> writes:

> On Tue, Feb 8, 2011 at 4:52 PM, Janne Grunau <janne-ffmpeg at jannau.net>wrote:
>
>> On Tue, Feb 08, 2011 at 07:14:58PM +0000, M?ns Rullg?rd wrote:
>> > Ronen Mizrahi <ronen at tversity.com> writes:
>> >
>> > > Hello,
>> > >
>> > > Looks like line 226 in dvbsub.c is neglecting to put the object version
>> in
>> > > the correct bits:
>> > > *q++ = s->object_version | (page_state << 2) | 3;
>> > >
>> > > It should be:
>> > >
>> > > *q++ = (s->object_version << 4) | (page_state << 2) | 3;
>> >
>> > That certainly _looks_ more reasonable.  Care to prepare a proper patch?
>>
>> yes, it's correct
>>
>> > > I am no dvbsub expert so I was hoping someone on the list can confirm.
>> In my
>> > > case the encoding did not play correctly in vlc before this patch but
>> does
>> > > after it, so I suspect it is indeed required.
>> >
>> > Which spec covers this?  Shouldn't be hard to verify the fix against
>> spec.
>>
>> ETSI EN 300 743 available for download from http://www.dvb.org
>>
>> Janne
>
>>
>
> Please see the patch attached.
>
> I did verify it against the spec and against vlc source code at:
> http://git.videolan.org/?p=vlc.git;a=blob;f=modules/codec/dvbsub.c;h=432f9b0bb18ee300080af6a30a1fc8648cae7492;hb=HEAD
>
> --- dvbsub.c	Wed Feb 09 12:19:56 2011
> +++ dvbsub1.c	Wed Feb 09 12:21:57 2011

Please send patches created with git format-patch.

-- 
M?ns Rullg?rd
mans at mansr.com