[FFmpeg-devel] [PATCH 1/2] Allow overriding SAMPLES by environment variable

[Baptiste Coudurier]

On 02/09/2011 12:55 PM, Martin Storsj? wrote:
> On Wed, 9 Feb 2011, M?ns Rullg?rd wrote:
>
>> Reimar D?ffinger<Reimar.Doeffinger at gmx.de>  writes:
>>
>>> ---
>>>   configure |    2 +-
>>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/configure b/configure
>>> index 2077397..44471b2 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -3248,7 +3248,7 @@ SLIB_CREATE_DEF_CMD=${SLIB_CREATE_DEF_CMD}
>>>   SLIB_EXTRA_CMD=${SLIB_EXTRA_CMD}
>>>   SLIB_INSTALL_EXTRA_CMD=${SLIB_INSTALL_EXTRA_CMD}
>>>   SLIB_UNINSTALL_EXTRA_CMD=${SLIB_UNINSTALL_EXTRA_CMD}
>>> -SAMPLES=$samples
>>> +SAMPLES?=$samples
>>>   EOF
>>
>> Why?  We don't do this for any other settings.
>
> Being able to override it by doing "export SAMPLES=<whatever>", outside of
> the actual configure/build commands, I guess. I can see the value in that,
> but OTOH I can see it being kind of problematic that the build system
> reacts to such a genericly named env variable, too.

Yup that would be useful, that's actually the first thing I tried when 
running fate tests. I had no idea it was set by configure.

-- 
Baptiste COUDURIER
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org