[FFmpeg-devel] [PATCH 1/2] Allow overriding SAMPLES by environment variable

[Michael Niedermayer]

On Thu, Feb 10, 2011 at 12:25:21AM +0100, Diego Biurrun wrote:
> On Thu, Feb 10, 2011 at 12:12:55AM +0100, Michael Niedermayer wrote:
> > On Wed, Feb 09, 2011 at 11:57:43PM +0100, Diego Biurrun wrote:
> > > On Wed, Feb 09, 2011 at 11:32:38PM +0100, Janne Grunau wrote:
> > > > On Wed, Feb 09, 2011 at 02:19:17PM -0800, Baptiste Coudurier wrote:
> > > > > 
> > > > > On 02/09/2011 02:13 PM, Diego Biurrun wrote:
> > > > > > On Wed, Feb 09, 2011 at 07:32:06PM +0100, Reimar D?ffinger wrote:
> > > > > >> ---
> > > > > >>   configure |    2 +-
> > > > > >>   1 files changed, 1 insertions(+), 1 deletions(-)
> > > > > >>
> > > > > >> --- a/configure
> > > > > >> +++ b/configure
> > > > > >> @@ -3248,7 +3248,7 @@ SLIB_CREATE_DEF_CMD=${SLIB_CREATE_DEF_CMD}
> > > > > >>   SLIB_UNINSTALL_EXTRA_CMD=${SLIB_UNINSTALL_EXTRA_CMD}
> > > > > >> -SAMPLES=$samples
> > > > > >> +SAMPLES?=$samples
> > > > > >
> > > > > > Is setting it through configure a hassle?
> > > > > 
> > > > > I think so.
> > > > 
> > > > make SAMPLES=path/to/fate
> > > > 
> > > > works without specifying the path at configure time
> > > 
> > > I thought I had mentioned this at some point already, apparently
> > > I did not.  Is that enough for you, Reimar?
> > 
> > I think this is undocumented
> 
> It is the standard way of passing variables to Make, same as 'make V=1'.

"how to pass"  (well known and documented in the make manual id guess)
"what to pass" (undocumented and obviously what was meant)

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110210/069edef0/attachment.pgp>