[FFmpeg-devel] [PATCH] CrystalHD decoder support v3
Philip Langdale
philipl
Thu Feb 10 05:53:17 CET 2011
On Tue, 8 Feb 2011 10:47:30 +0100 (CET)
Gwenole Beauchesne <gbeauchesne at splitted-desktop.com> wrote:
> Hi,
>
> On Sat, 5 Feb 2011, Philip Langdale wrote:
>
> >>> + if (output.PicInfo.height == 1088)
> >>> + avctx->height = 1080;
> >>
> >> why this special case? please add a comment.
> >
> > This came from the xbmc crystalhd code, but there's no particular
> > reason for it - I think they were trying to be friendly to
> > mis-encoded files. I've removed it.
>
> I think it was a bug with 70012 that did not support > 1080
> correctly. I will have to dig through mails, I am not very sure.
I did a quick test and saw the 70012 implicitly clip to 1080 while
the 70015 did not. Perhaps with earlier firmwares, it would fail to
play?
--phil
More information about the ffmpeg-devel
mailing list