[FFmpeg-devel] [PATCH 1/2] Allow overriding SAMPLES by environment variable

[Reimar Döffinger]

On Thu, Feb 10, 2011 at 07:34:54PM +0000, M?ns Rullg?rd wrote:
> Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
> > No. There is no one big issue I am trying to solve, but a whole
> > bunch of minor annoyances:
> > specifying it for configure means you either have to use a wrapper
> > script or write the path each time. It also means you have
> > to rerun configure when you move the samples.
> > Specifying it on the make command-line also means writing it each
> > time or using a wrapper.
> > For both, forgetting it means that "make fate" (I think at least
> > it was that command) silently does not run those tests.
> > Allowing it to be set via an environment variable allows fixing
> > all these minor issues in a very convenient way by just setting
> > it up once in the login script and it works even in case you make
> > a completely new checkout or whatever.
> > Note that for this purpose it would be completely sufficent (maybe
> > even preferable) if the environment variable was used only
> > when a samples path is not specified in any other way.
> 
> Does the patch[1] I posted last night work for you?

Yes, going by the quick test I did it does (quick being relative,
I ended up recompiling FFmpeg).
Maybe adding to the configure --samples description "if not specified uses
the value $FATE_SAMPLES has when make is invoked".
Something that's actually understandable would of course be better.