[FFmpeg-devel] [PATCH 1/2] Allow overriding SAMPLES by environment variable

[Reimar Döffinger]

On Wed, Feb 09, 2011 at 11:46:10PM +0000, M?ns Rullg?rd wrote:
> Benjamin Larsson <banan at ludd.ltu.se> writes:
> 
> > On 02/09/2011 07:32 PM, Reimar D?ffinger wrote:
> >> ---
> >>  configure |    2 +-
> >>  1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> diff --git a/configure b/configure
> >> index 2077397..44471b2 100755
> >> --- a/configure
> >> +++ b/configure
> >> @@ -3248,7 +3248,7 @@ SLIB_CREATE_DEF_CMD=${SLIB_CREATE_DEF_CMD}
> >>  SLIB_EXTRA_CMD=${SLIB_EXTRA_CMD}
> >>  SLIB_INSTALL_EXTRA_CMD=${SLIB_INSTALL_EXTRA_CMD}
> >>  SLIB_UNINSTALL_EXTRA_CMD=${SLIB_UNINSTALL_EXTRA_CMD}
> >> -SAMPLES=$samples
> >> +SAMPLES?=$samples
> >>  EOF
> >>  
> >>  get_version(){
> >
> > LGTM.
> 
> I've rejected this one before, and I'm doing it again.  Using an env var
> with such a generic name is asking for trouble.  I would consider using
> a more specific env var, but only if no path was explicitly set by configure.
> Something like this should have that effect:
> 
> diff --git a/configure b/configure
> index a3ca15d..2b82efb 100755
> --- a/configure
> +++ b/configure
> @@ -3245,7 +3245,7 @@ SLIB_CREATE_DEF_CMD=${SLIB_CREATE_DEF_CMD}
>  SLIB_EXTRA_CMD=${SLIB_EXTRA_CMD}
>  SLIB_INSTALL_EXTRA_CMD=${SLIB_INSTALL_EXTRA_CMD}
>  SLIB_UNINSTALL_EXTRA_CMD=${SLIB_UNINSTALL_EXTRA_CMD}
> -SAMPLES=$samples
> +SAMPLES=${samples:-\$(FATE_SAMPLES)}
>  EOF
>  
>  get_version(){

Ok, though some doc (e.g. in the configure --help ouput as suggested in
my other mail) is welcome.