[FFmpeg-devel] [PATCH 2/2] mmst: don't look for a hr field in ping messages

Diego Elio Pettenò flameeyes
Sun Feb 13 22:20:26 CET 2011


Il giorno sab, 12/02/2011 alle 16.45 -0500, Ronald S. Bultje ha scritto:
> 
> +            if (read_result >= 44) {
> +                hr = AV_RL32(mms->in_buffer + 40);
> +                if (hr) { 

LGTM

<bikeshedding>
although I would have used a single
if ( (read_result >= 44 ) && (hr = AVRL_ ...
</bikeshedding>

-- 
Diego Elio Petten? ? Flameeyes
http://blog.flameeyes.eu/




More information about the ffmpeg-devel mailing list