[FFmpeg-devel] [PATCH] Cosmetics: adopt compact notation in disabled code.

[Måns Rullgård]

Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:

> On date Monday 2011-02-14 10:32:54 +0000, M?ns Rullg?rd encoded:
>> Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
> [...]
>> > Subject: [PATCH] In ffplay adopt compact notation in code which sets aspect ration from
>> >  the DTG active format.
>> >
>> > This is legacy code, since it's not clear why it was left behind I'm
>> > leaving the logic untouched. Improve readability.
>> > ---
>> >  ffplay.c |   28 +++++++---------------------
>> >  1 files changed, 7 insertions(+), 21 deletions(-)
>> >
>> > diff --git a/ffplay.c b/ffplay.c
>> > index 170acfd..be26150 100644
>> > --- a/ffplay.c
>> > +++ b/ffplay.c
>> > @@ -723,27 +723,13 @@ static void video_image_display(VideoState *is)
>> >  #if 0
>> >          switch(is->video_st->codec->dtg_active_format) {
>> >          case FF_DTG_AFD_SAME:
>> 
>> That code has _never_ been enabled.  Just delete it.
>> 
>> The DTG thing appears to be some additional aspect ratio signalling used
>> in DVB, and this is clearly the wrong way to handle it.  It does not
>> belong in AVCodecContext at all IMHO.  Instead, the decoder should set
>> sample_aspect_ratio properly.
>
> OK, you convinced me.
>
> I confirm that the code was there since the inception of ffplay, and
> never enabled.
> -- 
> FFmpeg = Fantastic and Fast Mournful Prodigious Extroverse Gigant
>
> From 3a27c69b8f08caa31158119230af31e8cf2ca327 Mon Sep 17 00:00:00 2001
> From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> Date: Sat, 12 Feb 2011 18:25:53 +0100
> Subject: [PATCH] Remove disabled legacy code in ffplay.
>
> The code was setting aspect ratio from the DTG active format, and was
> present and disabled since the creation of ffplay.
>
> See thread:
> Subject: [FFmpeg-devel] [PATCH] Cosmetics: adopt compact notation in
>         disabled code.
> Date: Sat, 12 Feb 2011 18:46:19 +0100
> ---
>  ffplay.c |   34 ----------------------------------
>  1 files changed, 0 insertions(+), 34 deletions(-)

OK, queued.

-- 
M?ns Rullg?rd
mans at mansr.com