[FFmpeg-devel] [PATCH] fix nsvdec.c compilation if DEBUG macro defined

[Ronald S. Bultje]

Hi,

On Tue, Feb 15, 2011 at 2:27 PM, Reimar D?ffinger
<Reimar.Doeffinger at gmx.de> wrote:
> On Tue, Feb 15, 2011 at 08:42:31AM -0500, Ronald S. Bultje wrote:
>> > @@ -623,7 +612,7 @@ null_chunk_retry:
>> > ? ? ? ? ?pkt->flags |= nsv->state == NSV_HAS_READ_NSVS ? AV_PKT_FLAG_KEY : 0; /* keyframe only likely on a sync frame */
>> > ?/*
>> > ? ? ? ? ?for (i = 0; i < MIN(8, vsize); i++)
>> > - ? ? ? ? ? ?PRINT(("NSV video: [%d] = %02x\n", i, pkt->data[i]));
>> > + ? ? ? ? ? ?av_dlog(s, "NSV video: [%d] = %02x\n", i, pkt->data[i]);
>> > ?*/
>> > ? ? ?}
>> > ? ? ?if(st[NSV_ST_VIDEO])
>>
>> gcc is smart enough to remove the loop, so the /* and */ are unnecessary.
>
> First, it doesn't for e.g. -O0 I'd expect (though few if any use that I am sure),
> secondly it doesn't really fit with the kind of changes the patch does otherwise.
> Not that it matters much, but mixing that kind of changes makes it really difficult
> to write an accurate log message.

I don't care much about performance at -O0 (that'd be kind of silly).
I agree with the second part, I'll split it in multiple commits in the
future.

Ronald