[FFmpeg-devel] Another possible bug in dvbsub.c

[Måns Rullgård]

Ronen Mizrahi <ronen at tversity.com> writes:

> On Sat, Feb 12, 2011 at 5:27 PM, Ronen Mizrahi <ronen at tversity.com> wrote:
>
>> Hello,
>>
>> The problem with current dvbsub encoded with ffmpeg is that the subtitles
>> are not remove from display as expected (they remain displayed for a much
>> longer period, unless some other sub replaces them). This was tested with
>> VLC, ffplay, and also with other hardware devices (set-top-boxes).
>>
>> By comparing to VLC code base (
>> http://git.videolan.org/?p=vlc.git;a=blob;f=modules/codec/dvbsub.c;h=432f9b0bb18ee300080af6a30a1fc8648cae7492;hb=HEAD)
>> we were able to make a small change that seem to have fixed the
>> problem: when hide_state is TRUE, no region related information should be
>> written. This is unlike the current code where it does write the region ids
>> and their x,y position, as well as some other information.
>>
>> Since I am not a dvbsub expert and since the spec is not very clear with
>> regard to this situation I wanted to see if someone on the list can confirm
>> this correction. If so, I am happy to submit a patch.
>>
>>
> Any feedback from someone on the list? Would you consider a patch?

Patches that make things work better are always welcome.  I don't know
the DVB specs enough to comment on your findings, but you are probably
right.

-- 
M?ns Rullg?rd
mans at mansr.com