[FFmpeg-devel] [PATCH 2/4] vbv_delay AVOption for ABI compatibility

[Michael Niedermayer]

On Wed, Feb 16, 2011 at 12:06:09PM +0000, M?ns Rullg?rd wrote:
> Janne Grunau <janne-ffmpeg at jannau.net> writes:
> 
> > From: Michael Niedermayer <michaelni at gmx.at>
> >
> > Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
> > ---
> >  libavcodec/options.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/libavcodec/options.c b/libavcodec/options.c
> > index 57e0804..e4bc8a6 100644
> > --- a/libavcodec/options.c
> > +++ b/libavcodec/options.c
> > @@ -435,6 +435,7 @@ static const AVOption options[]={
> >  {"thread_type", "select multithreading type", OFFSET(thread_type), FF_OPT_TYPE_INT, FF_THREAD_SLICE|FF_THREAD_FRAME, 0, INT_MAX, V|E|D, "thread_type"},
> >  {"slice", NULL, 0, FF_OPT_TYPE_CONST, FF_THREAD_SLICE, INT_MIN, INT_MAX, V|E|D, "thread_type"},
> >  {"frame", NULL, 0, FF_OPT_TYPE_CONST, FF_THREAD_FRAME, INT_MIN, INT_MAX, V|E|D, "thread_type"},
> > +{"vbv_delay", "initial buffer fill time in periods of 27Mhz clock", 0, FF_OPT_TYPE_INT64, 0, 0, INT64_MAX},
> >  {NULL},
> >  };
> 
> J-B sent a better patch.

no
J-Bs patch is incomplete and more complex already.
The difference is adding a readonly flag that solves no real problem but makes
the code and API more complex
If one wanted, then what one could add is a "not a user option but for ABI"
flag not a read only flag.
a read only flag can be added too, but it doesnt solve the ABI issue and it
actually doesnt solve any issue anyone had.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 1
"Used only once"    - "Some unspecified defect prevented a second use"
"In good condition" - "Can be repaird by experienced expert"
"As is" - "You wouldnt want it even if you were payed for it, if you knew ..."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110216/fb8550a5/attachment.pgp>