[FFmpeg-devel] [PATCH 04/10] avio: rename ByteIOContext->AVIOContext

[Michael Niedermayer]

On Sat, Feb 19, 2011 at 10:15:21AM -0500, Ronald S. Bultje wrote:
> Hi,
> 
> On Sat, Feb 19, 2011 at 10:04 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Sat, Feb 19, 2011 at 12:42:48PM +0100, Anton Khirnov wrote:
> [..]
> >> ?140 files changed, 868 insertions(+), 864 deletions(-)
> >>
> >> diff --git a/ffserver.c b/ffserver.c
> >> index 7a16b2d..c2563b7 100644
> >> --- a/ffserver.c
> >> +++ b/ffserver.c
> >> @@ -163,7 +163,7 @@ typedef struct HTTPContext {
> >>
> >> ? ? ?/* RTSP state specific */
> >> ? ? ?uint8_t *pb_buffer; /* XXX: use that in all the code */
> >> - ? ?ByteIOContext *pb;
> >> + ? ?AVIOContext *pb;
> >> ? ? ?int seq; /* RTSP sequence number */
> >
> > The context has nothing to do with audio & video input/output.
> > I support ByteIOContext getting a prefix but not to remove the "Byte" part
> 
> AVByteIOContext is fine, avbyteio_*() is not ideal (IMO), too long.
> Are you OK with avio_*() along with AVByteIOContext?

iam not opposed, maybe avbio_*() would be better, i dont know


> 
> Also, what about URLContext? AVUrlContext OK or would you prefer
> something else?

i have no better idea ATM


> And for functions, is av_url_*() OK? (And then,
> likely, url_f*() will be renamed to avio_*().)

avuio_*() maybe for things taking a AVURLContext

But what IMHO is much more important is that things that are internal get a
ff prefix and not a av prefix.
internal is what is not used from outside. outside is
ffmpeg/ffplay/xine/vlc/mplayer

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110219/5f8a2487/attachment.pgp>