[FFmpeg-devel] [PATCH 2/2] avio: move init_put_byte() to a new private header and rename it

Anton Khirnov anton
Sun Feb 20 11:20:34 CET 2011


On Sun, Feb 20, 2011 at 12:11:52PM +0200, Martin Storsj? wrote:
> On Sun, 20 Feb 2011, Anton Khirnov wrote:
> 
> > init_put_byte should never be used outside of lavf, since
> > sizeof(AVByteIOContext) isn't part of public ABI.
> > ---
> >  libavformat/asfenc.c        |    5 +++--
> >  libavformat/avio.h          |    4 ++--
> >  libavformat/avio_internal.h |   35 +++++++++++++++++++++++++++++++++++
> >  libavformat/aviobuf.c       |   26 +++++++++++++++++++++-----
> >  libavformat/id3v2.c         |    3 ++-
> >  libavformat/matroskadec.c   |    9 +++++----
> >  libavformat/mmst.c          |    3 ++-
> >  libavformat/mov.c           |    3 ++-
> >  libavformat/mpegts.c        |    5 +++--
> >  libavformat/rdt.c           |    5 +++--
> >  libavformat/rtpdec_asf.c    |    5 +++--
> >  libavformat/rtpdec_qt.c     |    3 ++-
> >  libavformat/rtsp.c          |    3 ++-
> >  libavformat/sapdec.c        |    3 ++-
> >  14 files changed, 87 insertions(+), 25 deletions(-)
> >  create mode 100644 libavformat/avio_internal.h
> 
> We already have lavf/internal.h - could this function be added to that 
> header instead?

It's already pretty cluttered, and I expect that more avio.h functions
will be made internal. So I think creating a new header is better.

-- 
Anton Khirnov
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110220/b3bbe043/attachment.pgp>



More information about the ffmpeg-devel mailing list