[FFmpeg-devel] [PATCH] dsputil: make {add/put/put_signed}_pixels_clamped() public.

[Alex Converse]

On Sun, Feb 20, 2011 at 1:32 PM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> Hi,
>
> On Sun, Feb 20, 2011 at 4:04 PM, Alex Converse <alex.converse at gmail.com> wrote:
>> On Sun, Feb 20, 2011 at 10:25 AM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
>>> ---
>>> ?libavcodec/dsputil.c | ? 28 ++++++++++++++--------------
>>> ?libavcodec/dsputil.h | ? ?4 ++++
>>> ?2 files changed, 18 insertions(+), 14 deletions(-)
>>>
>>
>> Can you explain this a little more? Public symbols usually have an
>> "av" prefix. Why are we making these public?
>
> Comment should read "non-static", I'll change that locally. I'd like
> to call them from other non-DSPContext/dsputil.c files also, in this
> case vc1dsp.c, so I don't have to duplicate this code in vc1dsp.c.
>

Sounds good. Can we add them to the symbol hiding script at all? I
really wouldn't like seeing us inadvertently have to start freezing
dsputil symbols.

> Ronald
>