[FFmpeg-devel] [PATCH] Remove old VCSs from version.sh

[Alex Converse]

On Mon, Feb 21, 2011 at 1:50 AM, Reinhard Tartler <siretart at tauware.de> wrote:
> On Mon, Feb 21, 2011 at 09:07:10 (CET), Alex Converse wrote:
>
>> $subj
>>
>> From 4d7ae86e662d127988582f00734d8b8bd4c1b7cc Mon Sep 17 00:00:00 2001
>> From: Alex Converse <alex.converse at gmail.com>
>> Date: Mon, 21 Feb 2011 00:01:09 -0800
>> Subject: [PATCH] Remove old VCSs from version.sh
>> MIME-Version: 1.0
>> Content-Type: multipart/mixed; boundary="------------1"
>>
>> This is a multi-part message in MIME format.
>> --------------1
>> Content-Type: text/plain; charset=UTF-8; format=fixed
>> Content-Transfer-Encoding: 8bit
>>
>> ---
>> ?version.sh | ? 16 ----------------
>> ?1 files changed, 0 insertions(+), 16 deletions(-)
>>
>>
>> --------------1
>> Content-Type: text/x-patch; name="0001-Remove-old-VCSs-from-version.sh.patch"
>> Content-Transfer-Encoding: 8bit
>> Content-Disposition: attachment; filename="0001-Remove-old-VCSs-from-version.sh.patch"
>>
>> diff --git a/version.sh b/version.sh
>> index 3269e03..dc610d3 100755
>> --- a/version.sh
>> +++ b/version.sh
>> @@ -1,21 +1,5 @@
>> ?#!/bin/sh
>>
>> -# check for SVN revision number
>> -revision=$(cd "$1" && cat snapshot_version 2> /dev/null)
>
> Please keep support for the 'snapshot_version' file. It is used to
> specify the version number for out-of-vcs builds.
>

Can you give an example of where this snapshot_version is currently used?

The original documentation for snapshot_version says:

Read revision string from the file snapshot_version if available.
This will be used by daily snapshots without Subversion metadata.

It is in the group of revision probes that get prefixed with SVN-r
which implies that if it is still used it is at best wrong.

[...]