[FFmpeg-devel] [PATCH 1/2] libavformat: Add av_pkt_dump{, _log}2, taking a timebase parameter
Martin Storsjö
martin
Thu Feb 24 09:07:32 CET 2011
On Wed, 23 Feb 2011, Michael Niedermayer wrote:
> On Wed, Feb 23, 2011 at 11:21:42PM +0200, Martin Storsj? wrote:
> > This removes a fixme issue.
> > ---
> > libavformat/avformat.h | 16 ++++++++++++----
> > libavformat/utils.c | 26 +++++++++++++++++++-------
> > 2 files changed, 31 insertions(+), 11 deletions(-)
>
> I would suggest *AVStream to be passed instead of a time_base.
> Its more information that might be usefull in the future
> It avoids the mistake of passing the AVCodecContext timebase by mistake
> Its simpler
Ok, updated patchset following. The utils.c internal function still takes
an AVRational as parameter for now, since the fallback wrappers for the
old public API is easier to implement that way.
// Martin
More information about the ffmpeg-devel
mailing list