[FFmpeg-devel] [PATCH 1/2] libavformat: Add av_pkt_dump{, _log}2, taking an AVStream parameter

Michael Niedermayer michaelni
Fri Feb 25 02:54:46 CET 2011


On Thu, Feb 24, 2011 at 10:08:06AM +0200, Martin Storsj? wrote:
> This removes a fixme issue, by allowing the av_pkt_dump functions
> to use the correct time base.
> ---
>  libavformat/avformat.h |   16 ++++++++++++----
>  libavformat/utils.c    |   26 +++++++++++++++++++-------
>  2 files changed, 31 insertions(+), 11 deletions(-)

LGTM

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20110225/da8c944f/attachment.pgp>



More information about the ffmpeg-devel mailing list