[FFmpeg-devel] [rfc] merge the applehttp-urlprotocol into main

[Martin Storsjö]

On Mon, 28 Feb 2011, Luca Barbato wrote:

> On 02/28/2011 02:57 PM, Martin Storsj? wrote:
> > On Mon, 28 Feb 2011, Martin Storsj? wrote:
> > 
> >> On Mon, 28 Feb 2011, Luca Barbato wrote:
> >>
> >>> On 02/28/2011 12:54 PM, Martin Storsj? wrote:
> >>>> That might indeed be a better route. Although I don't think we currently 
> >>>> can handle registering a protocol that will catch any 
> >>>> applehttp+<whatever>://, at the moment we'd have to register the full 
> >>>> applehttp+<whatever> as protocol name.
> >>>>
> >>>> What would be a good way of handling this? Adding a flag to URLProtocol, 
> >>>> where a protocol can signal that it can work as a base protocol? That is, 
> >>>> if this flag is set, we'd try to match only the part of the URL scheme up 
> >>>> to the first + with this protocol name.
> >>>
> >>> might be useful go to this route and change the url splitter accordingly
> >>> in the long run.
> >>
> >> I'm not sure the url splitter in itself should be changed - there's no 
> >> inherent meaning in using + as a separator. I'll try to prototype the 
> >> thing I suggested above, though.
> > 
> > Implemented this in the attached patches. Do you think this looks like a 
> > sensible approach?
> > 
> > // Martin
> 
> 0002
> 
> proto_str might be truncated as is  w/out having the additional var.

We need to keep both the full and truncated version, IMO, since we don't 
know which protocols it actually will match, and we only compare the 
truncated version for the protocols that set the flag.

// Martin