[FFmpeg-devel] [PATCH] Remove Sonic experimental audio codec

[Alex Converse]

On Mon, Feb 28, 2011 at 8:29 AM, Stefano Sabatini
<stefano.sabatini-lala at poste.it> wrote:
> On date Monday 2011-02-28 17:26:57 +0100, Stefano Sabatini encoded:
>> On date Monday 2011-02-28 14:49:22 +0000, Mans Rullgard encoded:
>> > Since initially committed in 2004, this codec has only been touched
>> > for maintenanance. ?Functionally, it contains no novel ideas and
>> > its intended audience is better served by existing mature codecs.
>> >
>> > Signed-off-by: Mans Rullgard <mans at mansr.com>
>> > ---
>> > ?MAINTAINERS ? ? ? ? ? ?| ? ?1 -
>> > ?configure ? ? ? ? ? ? ?| ? ?3 -
>> > ?libavcodec/Makefile ? ?| ? ?3 -
>> > ?libavcodec/allcodecs.c | ? ?2 -
>> > ?libavcodec/sonic.c ? ? | ?977 ------------------------------------------------
>> > ?5 files changed, 0 insertions(+), 986 deletions(-)
>> > ?delete mode 100644 libavcodec/sonic.c
>>
>> Why was it designed/added in the first place?
>
> Also: this should require a major bump (i.e. removed conditionally to
> the next bump). And in general for this kind of changes expect some
> time (3 days / one week) so that all the interested parties can state
> their position before it's too late.

Why does this need a major bump?

Removing a *codec id* obviously requires a major bump.

avcodec_open() is allowed to fail. Removing sonic is just like making
"--disable-decoder=sonic --disable-encoder=sonic" always on.

--Alex