[FFmpeg-devel] [PATCH] graphparser: fix logic for updating the open_inputs/outputs in avfilter_graph_parse()

[Michael Niedermayer]

On Tue, Jul 05, 2011 at 06:40:20PM +0200, Stefano Sabatini wrote:
> On date Saturday 2011-07-02 17:07:59 +0200, Stefano Sabatini encoded:
> > On date Saturday 2011-07-02 16:45:32 +0200, Stefano Sabatini encoded:
> > > On date Saturday 2011-07-02 16:30:55 +0200, Stefano Sabatini encoded:
> > > > In particular, fix possible NULL pointer derefences, in case
> > > > open_inputs/outputs is NULL.
> > > > ---
> > > >  libavfilter/graphparser.c |   20 ++++++++++++--------
> > > >  1 files changed, 12 insertions(+), 8 deletions(-)
> > > 
> > > Discard this, not yet ready.
> > 
> > Updated.
> > -- 
> > FFmpeg = Fanciful Fierce Mere Powered Esoteric Gargoyle
> 
> > From 610dd874f0ead27e4986d4208b79867461d2d25c Mon Sep 17 00:00:00 2001
> > From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> > Date: Fri, 1 Jul 2011 16:31:16 +0200
> > Subject: [PATCH] graphparser: fix logic for updating the open_inputs/outputs in avfilter_graph_parse()
> > 
> > In particular, fix possible NULL pointer derefences, in case
> > open_inputs/outputs is NULL.
> > ---
> >  libavfilter/graphparser.c |   54 +++++++++++++++++++++++++--------------------
> >  1 files changed, 30 insertions(+), 24 deletions(-)
> 
> Ping.

it does LGTM after a quick look

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is not what we do, but why we do it that matters.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110706/bbfb1def/attachment.asc>