[FFmpeg-devel] missing } for { in libavcodec/g729dec.c patch included

[Stefano Sabatini]

On date Thursday 2011-07-14 19:11:21 -0400, DJ Cozatt encoded:
> Running cppcheck against the git version of ffmpeg it claimed an invalid
> number of character ({) in line 200
> 
> traced the issue to a missing } and added re-ran the analyzer no error
> reported for this file.
> 
> 
> add-missing-bracket.path David J Cozatt aka user99
> --- libavcodec/g729dec.orig	2011-07-13 22:37:34.226825065 -0400
> +++ libavcodec/g729dec.c	2011-07-13 00:32:45.680889697 -0400
> @@ -309,7 +309,7 @@
>                                       (!voicing && frame_erasure) ? 0 :
> ctx->gain_pitch,
>                                       ( voicing && frame_erasure) ? 0 :
> ctx->gain_code,
>                                       1 << 13, 14, SUBFRAME_SIZE);
> -		
> +		}
>              ctx->pitch_delay_int_prev = pitch_delay_int;
>      }

The file is never compiled and it was apparently broken since many
committs in the past (the closing brace is apparently missing since
commit 1a18912e491c55dcf6d3b10ed72ae041053ccca8).

Following patches looks reasonable, thus I wonder what's the sense of
fixing a disabled file.
-- 
FFmpeg = Frenzy and Forgiving Mastodontic Prodigious Enhanced Guru
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-g729dec-fix-weird-indent.patch
Type: text/x-diff
Size: 1619 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110715/774d566e/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-g729dec-add-missing-closing-brace.patch
Type: text/x-diff
Size: 738 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110715/774d566e/attachment-0001.bin>