[FFmpeg-devel] [PATCH] imgconvert: remove PixFmtInfo.pixel_type field
Michael Niedermayer
michaelni at gmx.at
Sun Jul 24 16:16:35 CEST 2011
On Sun, Jul 24, 2011 at 01:45:06AM +0200, Stefano Sabatini wrote:
> On date Saturday 2011-07-23 17:12:01 +0200, Michael Niedermayer encoded:
> > On Sat, Jul 23, 2011 at 03:58:56PM +0200, Stefano Sabatini wrote:
> > [...]
> > > [PIX_FMT_NV12] = {
> > > .color_type = FF_COLOR_YUV,
> > > - .pixel_type = FF_PIXEL_PLANAR,
> > > .depth = 8,
> > > },
> > > [PIX_FMT_NV21] = {
> > > .color_type = FF_COLOR_YUV,
> > > - .pixel_type = FF_PIXEL_PLANAR,
> > > .depth = 8,
> > > },
> >
> > does the output match for these ?
>
> No, and I don't think the av_picture_crop/pad code for NV12/21 ever
> worked.
no disagreement here
but to me NV12 is a planar format, theres a luma plane and a chroma
plane
not that i mind it much when the code doesnt work either way.
so commit what you prefer
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110724/734085a4/attachment.asc>
More information about the ffmpeg-devel
mailing list