[FFmpeg-devel] [PATCH] CrystalHD: Use mp4toannexb bitstream filter.

[Michael Niedermayer]

On Sun, Jun 12, 2011 at 11:22:18AM -0700, Philip Langdale wrote:
> On Sun, 12 Jun 2011 20:05:43 +0200
> Michael Niedermayer <michaelni at gmx.at> wrote:
> 
> > 
> > See write_frame() in ffmpeg.c on how to use
> > av_bitstream_filter_filter()
> 
> I think this adds up to the same thing as what I was doing before.
> Certainly when I switched to follow write_frame() the leak remained
> the same.
>  
> > About the leak, i suggest you try valgrind, it can pinpoint where
> > leaked memory comes from.
> 
> The leaked memory is all from alloc_and_copy in the filter - not
> really a surprise. I'll keep investigating but I think that there's
> a fundamental problem in the filter.

Well, you dont seem to free the data so its not surprising theres a
leak

when the filter allocates new memory it has to be freed, when it
doesnt allocate it, freeing leads to an error.
the return code from av_bitstream_filter_filter() says if memory was
allocated

and changing the avpkt->data pointer is not a good idea.

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

While the State exists there can be no freedom; when there is freedom there
will be no State. -- Vladimir Lenin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110612/197dbee5/attachment.asc>