[FFmpeg-devel] [PATCH] OpenAL 1.1 Capture Support
Stefano Sabatini
stefano.sabatini-lala at poste.it
Mon Jun 27 15:37:59 CEST 2011
On date Sunday 2011-06-26 22:44:47 -0400, Jonathan Baldwin encoded:
> >
> > Maybe this could be simplified, but I think it's safe to commit and
> > see if someone has better ideas.
> >
>
> The simpler the better ;-)
>
> >
> > Note: maybe we could add proper support to "booleans" in avopt.
> >
>
> That's probably a good idea, it could save a lot of boilerplate (such
> as the true/false option constants in this code) if there are enough
> things that require booleans. It could also make it easier on the
> user, depending on the interface.
>
> >
> > Looks fine to me, I'll test and commit in a few days if I see no
> > comments from other devs (and if it works for me).
> >
>
> Awesome. I look forward to contributing more.
>
> >
> > Tried to configure this natively on Mingw/Windows7, I had to replace
> > "-lOpenAL32.dll" with "-lOpenAL32", as the OpenAL SDK from creative has
> > not a .dll (it provides an OpenAL32.lib instead).
> >
>
> I wasn't sure if MinGW could use the Creative import library, I
> thought that perhaps it was in a different archive format or
> something, because I couldn't unar it (I know that *nix and MinGW
> native import libraries are ar archives of object files.) I guess I
> could've tried linking against it anyways...
>
> >
> > I updated the patch with a few cosmetical fixes and docs additions.
> >
>
> The updated patch works for me ;-)
Tested on MinGW/Windows7 and pushed.
I've been told that the ISC license is simpler, feel free to send a
patch for changing licence if you feel like that.
And thanks again for the nice job, this finally allows audio capture
on Windows :-).
--
FFmpeg = Fascinating and Fundamentalist Mega Powerful Enchanting Gadget
More information about the ffmpeg-devel
mailing list