[FFmpeg-devel] [PATCH] vsink_buffer: don't abort in case of missing frame

[Michael Niedermayer]

On Mon, Jun 27, 2011 at 11:49:22PM +0200, Stefano Sabatini wrote:
> Do not return AVERROR(EINVAL) in
> av_vsink_buffer_get_video_buffer_ref() if no frame is immediately
> returned, but keep requesting frames.
> 
> This is required for filters which cache frames, e.g. the tinterlace
> filter, for which a frame is not immediately returned at the first
> avfilter_request_frame() call.

This feels like a bug in tinterlace to me.
it could call request twice if it needs that to output a frame

I think its easier if request_frame() must output a frame or fail with
error.
otherwise i think every use of that function would need to be in a
loop and there might even be an issue with it doing infinite loops if
it never returns a frame but doesnt error out either

[...]
--
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Concerning the gods, I have no means of knowing whether they exist or not
or of what sort they may be, because of the obscurity of the subject, and
the brevity of human life -- Protagoras
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110628/7547d5b3/attachment.asc>