[FFmpeg-devel] [PATCH] lavf: make compute_pkt_fields2() return meaningful error values

Stefano Sabatini stefano.sabatini-lala at poste.it
Sat Mar 26 15:01:06 CET 2011


On date Monday 2011-03-21 17:47:03 +0100, Stefano Sabatini encoded:
> On date Monday 2011-03-21 03:04:14 +0100, Michael Niedermayer encoded:
[...]
> > > Ping?
> > 
> > no objection, not sure the new error codes are ideal though but i cant really
> > name better ones
> 
> Indeed, I'm quite unsatisfied as it is not very clear if these are
> "invalid parameters" errors or rather should be considered "invalid
> data errors".
> 
> These problems usually occur when copying malformed streams with
> invalid timestamps, e.g. non monotonically increasing DTS, see for
> example: https://roundup.ffmpeg.org/issue1551
> 
> Anyway I believe at the muxer level they should be considered an
> application error, since it is the application providing the
> timestamps which is doing something controversial (e.g. not
> checking/fixing the input values).
> 
> I'll push it if I make up my mind (or if someone else has a better
> suggestion), I'll post more about the TS issue soon.

Pushed.
-- 
FFmpeg = Friendly Furious Magical Peaceless Ecumenical Guru



More information about the ffmpeg-devel mailing list