[FFmpeg-devel] [patch][GSoC]WTV muxer (1_extract_wtv_common_code.patch)

[zhentan feng]

Hi

On Thu, Sep 8, 2011 at 7:58 AM, Michael Niedermayer <michaelni at gmx.at>wrote:

> Hi
>
> On Tue, Aug 23, 2011 at 09:40:58PM +0800, zhentan feng wrote:
> > Hi,
> >
> > On Sat, Aug 20, 2011 at 10:53 PM, Peter Ross <pross at xvid.org> wrote:
> >
> > > Comments against 1_extract_wtv_common_code.patch
> > >
> > > On Sun, Aug 14, 2011 at 09:07:59PM +0800, zhentan feng wrote:
> > > > Hi,
> > > > The attachment are 3 patches.
> > > > #1 patch extracts common code from wtvdec.c and wtvenc.c to wtv.c and
> > > wtv.h
> > >
> > > > diff --git a/libavformat/wtv.c b/libavformat/wtv.c
> > > > index 926f924..76fece5 100644
> > > > --- a/libavformat/wtv.c
> > > > +++ b/libavformat/wtv.c
> > > > @@ -39,6 +39,37 @@ const ff_asf_guid ff_mediatype_video =
> > > >  const ff_asf_guid ff_format_none =
> > > >
> > >
>  {0xD6,0x17,0x64,0x0F,0x18,0xC3,0xD0,0x11,0xA4,0x3F,0x00,0xA0,0xC9,0x22,0x31,0x96};
> > > >
> > > > +/* declare utf16le strings */
> > > > +#define _ , 0,
> > > > +const uint8_t timeline_le16[] =
> > > > +    {'t'_'i'_'m'_'e'_'l'_'i'_'n'_'e', 0};
> > > > +const uint8_t timeline_table_0_entries_Events_le16[] =
> > > > +
> > >
>  {'t'_'i'_'m'_'e'_'l'_'i'_'n'_'e'_'.'_'t'_'a'_'b'_'l'_'e'_'.'_'0'_'.'_'e'_'n'_'t'_'r'_'i'_'e'_'s'_'.'_'E'_'v'_'e'_'n'_'t'_'s',
> > > 0};
> > > > +const uint8_t table_0_entries_legacy_attrib_le16[] =
> > > > +
> > >
>  {'t'_'a'_'b'_'l'_'e'_'.'_'0'_'.'_'e'_'n'_'t'_'r'_'i'_'e'_'s'_'.'_'l'_'e'_'g'_'a'_'c'_'y'_'_'_'a'_'t'_'t'_'r'_'i'_'b',
> > > 0};
> > > > +const uint8_t table_0_entries_time_le16[] =
> > > > +
> > >
>  {'t'_'a'_'b'_'l'_'e'_'.'_'0'_'.'_'e'_'n'_'t'_'r'_'i'_'e'_'s'_'.'_'t'_'i'_'m'_'e',
> > > 0};
> > > > +#undef _
> > >
> > > need to prefix those symbols with ff_
> > >
> > >
> >
> > added the ff_ prefix for the common code.
> [...]
>
> > > Otherwise looks good.
>
> sorry for the delay ive missed that comment above from you in the
> previous mail ...
>
> patch applied, will push soon
>
> thanks
>
>

And the project have another patch named “[patch][GSoC]WTV muxer
(2_wtvenc.patch, 3_add_wtv_muxer.patch)” is still pending.
Thanks.

zhentan
-- 
Best wishes~