[FFmpeg-devel] [PATCH] lavfi: add ff_all_channel_layouts internal symbol

[Michael Niedermayer]

On Sat, Sep 10, 2011 at 09:45:16AM +0200, Stefano Sabatini wrote:
> On date Saturday 2011-09-10 03:46:23 +0200, Michael Niedermayer encoded:
> > On Sat, Sep 10, 2011 at 02:01:27AM +0200, Stefano Sabatini wrote:
> [...]
> > > > AVFilterFormats *avfilter_all_channel_layouts(void)
> > > > {
> > > >     static int64_t cls[] = {
> > > > #define A(x) (x), (x)|AV_CH_LOW_FREQUENCY
> > > > #define B(x) A(x|AV_CH_FRONT_CENTER), A(x|AV_CH_FRONT_LEFT|AV_CH_FRONT_RIGHT), A(x|AV_CH_FRONT_CENTER|AV_CH_FRONT_LEFT|AV_CH_FRONT_RIGHT)
> > > > #define C(x) B(x), B(x|AV_CH_BACK_LEFT|AV_CH_BACK_RIGHT), B(x|AV_CH_BACK_CENTER)
> > > > #define D(x) C(x), C(x|AV_CH_SIDE_LEFT|AV_CH_SIDE_RIGHT)
> > > >         D(0), D(AV_CH_STEREO_LEFT|AV_CH_STEREO_RIGHT)
> > > >     };
> > > > 
> > > >     for (i = 0; i < FF_ARRAY_ELEMS(cls); i++) {
> > > >         if (get_channel_layout_nb_channels(cls[i]) > 8) {
> > > >             cls[i]=AV_CH_FRONT_CENTER;
> > > >         }
> > > >     }
> > > >     return avfilter_make_format64_list(cls);
> > > > }
> > > 
> > > My problem is that I need the list as an int64_t list (for use in the
> > > audio sink). I could of course convert the formats list to int64_t,
> > > but would be awkward. That's why I proposed a static int64_t array.
> > 
> > Both your code and mine use a static int64_t array and convert it with
> > avfilter_make_format64_list()
> > 
> > the for() loop in mine is just there because we dont support >8
> > channels ATM, that would be remvoed once that is fixed.
> > 
> > Please elaborate on what the problem is
> 
> I need the list to be *public*, so I can use it in code like this:
> 
>             enum AVSampleFormat sample_fmts[] = { AV_SAMPLE_FMT_S16, -1 };
>             const int packing_fmts[] = { AVFILTER_PACKED, -1 };
>             const int64_t *chlayouts = avfilter_all_channel_layouts_int64;

const int64_t avfilter_all_channel_layouts_int64[] = {
#define A(x) (x), (x)|AV_CH_LOW_FREQUENCY
#define B(x) A(x|AV_CH_FRONT_CENTER), A(x|AV_CH_FRONT_LEFT|AV_CH_FRONT_RIGHT), A(x|AV_CH_FRONT_CENTER|AV_CH_FRONT_LEFT|AV_CH_FRONT_RIGHT)
#define C(x) B(x), B(x|AV_CH_BACK_LEFT|AV_CH_BACK_RIGHT), B(x|AV_CH_BACK_CENTER)
#define D(x) C(x), C(x|AV_CH_SIDE_LEFT|AV_CH_SIDE_RIGHT)
        D(0), D(AV_CH_STEREO_LEFT|AV_CH_STEREO_RIGHT),
        -1
};



[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110911/23923709/attachment.asc>