[FFmpeg-devel] [RFC] Change fallthrough logic for read_seek to be based on return value

[Reimar Döffinger]

On Mon, Sep 12, 2011 at 10:11:09PM +0200, Joakim Plate wrote:
> The gxf change was really the only change needed to make fate pass. However
> that change actually look wrong. So maybe fate should be updated there
> instead.

Why do you think it looks wrong? Index in GXF is rather special, in
particular it is not complete, so it can make sense to retry with
other methods.

> @@ -1810,10 +1810,12 @@ int av_seek_frame(AVFormatContext *s, int stream_index, int64_t timestamp, int f
>      if (s->iformat->read_seek)
>          ret = s->iformat->read_seek(s, stream_index, timestamp, flags);
>      else
> -        ret = -1;
> +        ret = AVERROR(ENOSYS);
>      if (ret >= 0) {
>          return 0;
>      }
> +    if (ret != AVERROR(ENOSYS))
> +        return -1;

What's the reason for not returning ret?